This repository has been archived by the owner on Feb 6, 2025. It is now read-only.
feat: add trie prefetch when executing blocks #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jul 11, 2024
unclezoro
reviewed
Jul 11, 2024
unclezoro
reviewed
Jul 11, 2024
unclezoro
reviewed
Jul 11, 2024
unclezoro
reviewed
Jul 11, 2024
unclezoro
reviewed
Jul 17, 2024
unclezoro
reviewed
Jul 17, 2024
unclezoro
reviewed
Jul 17, 2024
unclezoro
reviewed
Jul 17, 2024
|
Have you guys benchmarked this work yet? Pretty exciting and stuff we've talked about before, keen to see how well it does as state root is by far the bottleneck... |
Thank you for being so interested. We are currently conducting performance tests and will soon release the relevant data publicly. |
unclezoro
reviewed
Aug 28, 2024
unclezoro
reviewed
Aug 28, 2024
added 2 commits
August 29, 2024 16:10
unclezoro
changed the title
keefel
changed the title
yutianwu
reviewed
Sep 2, 2024
yutianwu
reviewed
Sep 2, 2024
yutianwu
approved these changes
Sep 2, 2024
unclezoro
approved these changes
Sep 3, 2024
keefel
changed the title
This was referenced Sep 6, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances merkleization efficiency by prefetching trie nodes from the database during execution.
Rationale
This pull request can enhance merkleization efficiency by approximately 56% for the BSC network.
Example
We separately tracked the time taken for inserting blocks, executing blocks, and calculating the state root during live sync. We will compare these metrics to gain insights into their performance.
BSC Test Result - Live sync 14K blocks, from 41550000 to 41564139.
Scatter Plot for Execution Time
Scatter Plot for State Root Calculation Time
Scatter Plot for Total Time
The Prefetch feature boosts state root calculation efficiency during BSC live sync without compromising block execution efficiency. This leads to a 56% decrease in state root calculation time and a 29% reduction in total block insertion time.
opBNB Test Result - Live sync 14K blocks, from 33180000 to 33194139.
Scatter Plot for Execution Time
Scatter Plot for State Root Calculation Time
Scatter Plot for Total Time
In the case of opBNB, the execution time, state root calculation time, and total time for block insertion are all relatively small. Prefetching optimization doesn't show clear benefits for opBNB. This could be due to the small world state tree of opBNB. When opBNB runs on a machine with 128GB of memory, most trie nodes are already in memory, making prefetch optimization ineffective.
Changes
Notable changes:
Potential Impacts